Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementing new methods from servercfg.DoltgresConfig #1113

Merged
merged 4 commits into from
Jan 16, 2025
Merged

Implementing new methods from servercfg.DoltgresConfig #1113

merged 4 commits into from
Jan 16, 2025

Conversation

fulghum
Copy link
Contributor

@fulghum fulghum commented Jan 9, 2025

Implements the new IsUserSpecified() and SkipRootUserInitialization() methods from servercfg.DoltgresConfig, added in dolthub/dolt#8690

@fulghum fulghum mentioned this pull request Jan 9, 2025
Merged
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2025 •
edited
Loading

Main PR
covering_index_scan_postgres 362.88/s 368.66/s +1.5%
index_join_postgres 151.25/s 154.21/s +1.9%
index_join_scan_postgres 182.91/s 184.99/s +1.1%
index_scan_postgres 12.54/s 12.56/s +0.1%
oltp_point_select 2863.83/s 2824.62/s -1.4%
oltp_read_only 1899.22/s 1900.52/s 0.0%
select_random_points 112.05/s 109.92/s -2.0%
select_random_ranges 133.34/s 133.19/s -0.2%
table_scan_postgres 11.78/s 11.95/s +1.4%
types_table_scan_postgres 5.61/s 5.63/s +0.3%

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2025 •
edited
Loading

Main PR
Total 42090 42090
Successful 15557 15559
Failures 26533 26531
Partial Successes1 5226 5226
Main PR
Successful 36.9613% 36.9660%
Failures 63.0387% 63.0340%

${\color{lightgreen}Progressions (2)}$

join

QUERY: SELECT * FROM
  (SELECT name, n as s1_n FROM t1) as s1
FULL JOIN
  (SELECT name, 2 as s2_n FROM t2) as s2
ON (s1_n = s2_n);

QUERY: select * from int4_tbl a full join int4_tbl b on false;

Footnotes

  1. These are tests that we're marking as Successful, however they do not match the expected output in some way. This is due to small differences, such as different wording on the error messages, or the column names being incorrect while the data itself is correct. ↩

@fulghum fulghum force-pushed the fulghum/server_config branch from 727538e to 0de6241 Compare January 13, 2025 19:16
@BrewTestBot BrewTestBot mentioned this pull request Jan 15, 2025
Merged
@fulghum
Reload dEnv instance from data-dir in configuration, now that sqlserv…
4db381a 
…er.ConfigureServices() doesn't handle this anymore
zachmu
zachmu approved these changes Jan 16, 2025
View reviewed changes
Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fulghum fulghum merged commit b985d60 into main Jan 16, 2025
14 checks passed
@fulghum fulghum deleted the fulghum/server_config branch January 16, 2025 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachmu zachmu zachmu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fulghum @zachmu